Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for positional arguments #41189

Merged
merged 3 commits into from Sep 12, 2022

Conversation

kssenii
Copy link
Member

@kssenii kssenii commented Sep 11, 2022

Changelog category (leave one):

  • Bug Fix (user-visible misbehavior in official stable or prestable release)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

Fix positional arguments exception Positional argument out of bounds. Closes #40634.

@robot-clickhouse robot-clickhouse added the pr-bugfix Pull request with bugfix, not backported by default label Sep 11, 2022
@alexey-milovidov alexey-milovidov self-assigned this Sep 11, 2022
@alexey-milovidov
Copy link
Member

fatal: unable to access 'https://github.com/ClickHouse/clickhouse-odbc.git/': The requested URL returned error: 500
2022-09-11 23:42:23 remote: Internal Server Error.

GitHub was down.

@den-crane
Copy link
Contributor

Let's backport it to 22.8 to fix this issue in LTS.

@alexey-milovidov alexey-milovidov added the pr-must-backport Pull request should be backported intentionally. Use this label with great care! label Dec 8, 2022
@den-crane den-crane added pr-must-backport Pull request should be backported intentionally. Use this label with great care! and removed pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Jan 15, 2023
@den-crane
Copy link
Contributor

@Felixoid it seems must-backport magic does not work here

@Felixoid
Copy link
Member

@Felixoid
Copy link
Member

Well, again we have an issue after #43829

Now the https://github.com/ClickHouse/ClickHouse/blob/master/tests/ci/cherry_pick.py#L315-L318 executes git merge-base origin/22.3 origin/master and there is:

commit 3eec14790628077ce56bf74e92745f3ea5c917fc
Merge: 120234b512d c822c8161ff
Author: Dan Roscigno <dan@roscigno.com>
Date:   Tue Nov 8 20:27:14 2022 -0500

I'll try to find more reliable way to find the first commit

@Felixoid
Copy link
Member

Should be fixed in #45466, let's see https://github.com/ClickHouse/ClickHouse/actions/runs/3967814934

@Felixoid
Copy link
Member

Well, obviously, we can't automatically create a backport for anything merged in #43829, since git consider it already being in 22.3

@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jan 24, 2023
kssenii added a commit that referenced this pull request Jan 26, 2023
Backport #41189 to 22.8: Fix for positional arguments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-bugfix Pull request with bugfix, not backported by default pr-must-backport Pull request should be backported intentionally. Use this label with great care!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

enable_positional_arguments converts fields into numbers
6 participants