Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Data Skipping Indices fix #4286

Merged
merged 181 commits into from Feb 9, 2019
Merged

Conversation

@nikvas0
Copy link
Contributor

nikvas0 commented Feb 6, 2019

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Fixes for #4143

  • review fix
  • fixed "create table as table"
  • fixed bugs in the unique index
@nikvas0

This comment has been minimized.

Copy link
Contributor Author

nikvas0 commented Feb 6, 2019

#4143 (comment)
MergeTreeReaderStream is moved MergeTreeDataReader::Stream, so I decided not to touch this code in order not to make more bugs.

11 5 4.7 6.50 cba b 2014-06-11
12 5 4.7 6.50 cba b 2015-01-01
"rows_read": 4,
"rows_read": 2,

This comment has been minimized.

Copy link
@nikvas0

nikvas0 Feb 7, 2019

Author Contributor

There is 2 because KeyCondition does not drop out one granule.
https://gist.github.com/nikvas0/528eea3bf556317fb699bd5994e680b4

@nikvas0 nikvas0 changed the title Data Skipping Indices fix [WIP] Data Skipping Indices fix Feb 7, 2019
@nikvas0 nikvas0 mentioned this pull request Feb 8, 2019
@alexey-milovidov alexey-milovidov merged commit 9650c4a into ClickHouse:master Feb 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.