Add last_exception_time to replication_queue #45457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tavplubix
added
the
can be tested
tavplubix
approved these changes
Jan 20, 2023
|
Hello @tavplubix , may I know why is it marked as draft? |
|
Because of failed tests |
|
Noted, let me check |
|
Integration tests (tsan) [6/6] - test_azure_blob_storage_zero_copy_replication is known to be flaky |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Add a new column
last_exception_timeto system.replication_queueTwo changes are contained in this PR:
last_exception_timeis added to replication_queue to reflect the time when the last exception is raised2.the full stack trace of the last exception is saved instead of the exception message
These changes save us a lot of time to search the text log to find out when and what the exact exception occurs.