FINAL SAMPLE #7907
Merged
FINAL SAMPLE #7907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| /// We do spoil available_real_columns here, but it is not used later. | ||
| auto sampling_column_type = data.primary_key_sample.getByName(data.sampling_expr_column_name).type; | ||
| available_real_columns.emplace_back(data.sampling_expr_column_name, std::move(type)); |
alexey-milovidov
approved these changes
Nov 25, 2019
KochetovNicolai
added
the
pr-improvement
|
[#CLICKHOUSE-1219] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Fix error
Column ... already existswhile usingFINALandSAMPLEtogether, e.g.select count() from table final sample 1/2. Fixes #5186Detailed description (optional):
It happened because sample expression is a part of PK, and it was calculated twice if we use final.