Add restrictions for several sources of external dictionaries #8127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alesapin
commented
Dec 10, 2019
| return DictionaryFactory::create(name, *configurationFromAST, "dictionary", context, true); | ||
| } | ||
|
|
||
| bool DictionaryFactory::isComplex(const std::string & layout_type) const |
There was a problem hiding this comment.
Not related to the main code of this PR.
alesapin
commented
Dec 10, 2019
| except QueryRuntimeException as ex: | ||
| assert 'is not allowed in config.xml' in str(ex) | ||
|
|
||
| def test_file_dictionary_restrictions(started_cluster): |
There was a problem hiding this comment.
No test for library source, but it's quite complex to implement.
alexey-milovidov
changed the title
alesapin
force-pushed
the
restrictions_for_external_dictionaries_from_ddl
branch
from
23d4c9a
to
a2180b0
Compare
|
failed test flap, so I'll merge it. |
alexey-milovidov
added
the
pr-bugfix
alexey-milovidov
pushed a commit
that referenced
this pull request
Jan 17, 2020
…ctionaries_from_ddl Add restrictions for several sources of external dictionaries
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Add additional checks for external dictionaries created from DDL-queries. Now it's not possible to create dictionaries with
Executablesource with DDL. Files for dictionaries fromFilesource have to be located inuser_filesdirectory. Remote hosts for HTTP dictionaries now checked withremote_url_allow_hostssection from config. Shared libraries for corresponding dictionaries' sources have to be placed indictionaries_libfolder.May cause some compatibility problems.