Using libc++ even with gcc #8311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexey-milovidov
added
the
pr-build
ghost
requested review from
|
Perf tests have failed for reason. Need to investigate. |
Merged
|
ORDER BY became much slower. |
|
Performance test is Ok and sorting performance was fought back almost two times. |
|
And there was unexpected speedup in some queries. For example, formatting in Pretty formants was improved about 40%. Overall performance improvement is about 2%. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (up to few sentences, required except for Non-significant/Documentation categories):
Release gcc builds now use
libc++instead oflibstdc++. Recentlylibc++was used only with clang. This will improve consistency of build configurations and portability.