Add semicolons_inline option to clickhouse format

[ZelvaMan]

Add semicolons_inline option to clickhouse-format to make it more convenient to use as formatter in IDE. It doesn't change default behavior

Changelog category (leave one):

• New Feature

Changelog entry:

• Add --semicolons_inline option to format queries so that semicolons are placed on the last line instead of on a new line

Documentation entry for user-facing changes:

The description of the CLI argument should be enough

[clickhouse-gh]

Workflow [PR], commit [019235c]

Summary: ❌

job_name	test_name	status	info	comment
Stateless tests (amd_binary, old analyzer, s3 storage, DatabaseReplicated, parallel)		failure
	03212_variant_dynamic_cast_or_default	FAIL
Stateless tests (amd_debug, sequential)		failure
	03174_exact_rows_before_aggregation	FAIL

[pamarcos]

Thanks for the contribution! Could you add a test to ensure this does what's supposed to do? That way we'll ensure we won't break it

Take a look at a similar example at https://github.com/ClickHouse/ClickHouse/blob/b6d1cd80c1e49fcd0bab17d9b2eb452c8113f6ed/tests/queries/0_stateless/00948_format_in_with_single_element.sh

[pamarcos]

Add semicolons_inline option to clickhouse-format to make it more convenient to use as formatter in IDE

Why does it make it more convenient to use in an IDE?

[ZelvaMan]

Hi, thanks for looking at my MR, I will add tests.

Why does it make it more convenient to use in an IDE?

This and the other MR I am working on would enable me to use clickhouse-format as formatter in nvim, because it would make the output same of formatters other people on my team use.

[CLAassistant]

All committers have signed the CLA.

[ZelvaMan]

Hi, I see there are still some failing tests, but i don't see how i could have caused them. I there anything I still need to do from my side?

[pamarcos]

Hi, I see there are still some failing tests, but i don't see how i could have caused them. I there anything I still need to do from my side?

Hi! Not your fault, just some flaky tests. No need to do anything on your side. I merged master, modified the CHANGELOG entry to make the new parameter more explicit and also fixed the style issue our CI found. If you're happy with the current changes and give me green light, I will follow on this PR to make sure it lands in master.

[ZelvaMan]

Yeah I am happy with the changes, thanks for the help with CI.