fix stack overflow issue when using initializer_list #9367
Conversation
ghost
requested review from
|
It is not clear for me what problem was solved. Could you please explain it a little bit or add a test? |
|
hello @KochetovNicolai, when running dbms/src/DataStreams/tests/collapsing_sorted_stream.cpp, i've an exit code 11 and when debugging with lldb, i found the stack is full of calls on It seems that this method is calling itself recursively. I'm running the program on MacOS 10.14.6 with clang 8. |
|
I have also faced this issue. It cannot happen in production, because this constructor is unused (it only happens in separate test programs). I tried to fix it some time ago but faced some difficulties. Need to review the fix. |
|
Thanks for your feedback, @alexey-milovidov. Feel free to comment on the code. The fix is done together with @LeoErcolanelli who contributed to some features previsouly. |
| @@ -30,13 +30,13 @@ try | |||
| ColumnWithTypeAndName column1; | |||
| column1.name = "Sign"; | |||
| column1.type = std::make_shared<DataTypeInt8>(); | |||
| column1.column = ColumnInt8::create({1, -1}); | |||
| column1.column = ColumnInt8::create({static_cast<int8_t>(1), static_cast<int8_t>(-1)}); | |||
There was a problem hiding this comment.
Why don't make the type of initializer list generic in ColumnVector and PODArray constructors? Let me try to do it in subsequent PR...
alexey-milovidov
added
pr-build
|
@alexey-milovidov is it normal that the CI is not completely green? Do tests fail randomly? |
|
It isn't. Fails are not random. |
* Generic constructor of ColumnVector from initializer list #9367 * Fixed build * Fixed error
fix stack overflow issue when using initializer_list (cherry picked from commit ab0bb7a)
I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Fix unit test
collapsing_sorted_stream.Detailed description / Documentation draft:
Fix stack overflow issue in copy on write pointer when using initializer_list
The
createfunction inside COWHelper calls itself when called with initializer_list