Fix nested fields expression in api reference docs pages #3379
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Our markdown generation for API response payloads returns incomplete tables and response payloads for any response that has nested fields.
A few examples—
https://clickhouse.com/docs/cloud/manage/api/keys-api-reference
Current result:

Expected result:
And another, flagged by @shribigb

https://clickhouse.com/docs/cloud/manage/api/usageCost-api-reference
Current result:
Expected result:
Resolution
The markdown generation needed a recursive function that checks if each field in the response contains properties or a ref. If the latter, it needs to extract the nested fields from the raw schema and generate some markdown for them. One dilemma is that markdown tables do not support nesting. as a result, the recursive method here will take an optional
fieldPrefixarg that is appended in JS-style notation to the beginning of the final field name. taking the aboveusageCostas an example, a payload structure like:will return field names like:
cc @rsickles - we should merge this before announcing new billing API endpoint.