Autogenerate global server settings #3530
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
|
@Blargian is attempting to deploy a commit to the ClickHouse Team on Vercel. A member of the Team first needs to authorize it. |
|
|
||
| ./clickhouse -q " | ||
| WITH | ||
| settings_outside_source AS |
There was a problem hiding this comment.
To avoid confusion, could you name the scalar variable settings_outside_source perhaps server_settings_outside_source?
| replaceRegexpAll(replaceRegexpAll(g[2], '\n(Type|Default( value)?): [^\n]+\n', ''), '^\n+|\n+$', '') AS doc | ||
| FROM file('_server_settings_outside_source.md', RawBLOB) | ||
| ), | ||
| settings_in_source AS |
There was a problem hiding this comment.
settings_in_source --> server_settings_in_source
| replaceRegexpAll(description, '(?m)^[ \t]+', '') AS description | ||
| FROM system.server_settings | ||
| ), | ||
| combined_settings AS |
| ( | ||
| SELECT | ||
| '--- | ||
| description: ''This section contains descriptions of server settings that cannot be |
There was a problem hiding this comment.
L. 162/163 sound like there are also server settings which can be changed at the session or query level. Maybe [...], i.e. settings which cannot be changed at the session or query level?
| description: ''This section contains descriptions of server settings that cannot be | ||
| changed at the session or query level.'' | ||
| keywords: [''global server settings''] | ||
| sidebar_label: ''Global Server Settings'' |
| # Global Server Settings | ||
| This section contains descriptions of server settings that cannot be changed at |
| # Global Server Settings | ||
| This section contains descriptions of server settings that cannot be changed at | ||
| the session or query level. These settings are stored in the `config.xml` file |
There was a problem hiding this comment.
The 2nd sentence is slightly incorrect: a) the cfg file can be named different than config.xml (as long as it is an xml or json file), b) it is technically not stored "on" the ClickHouse server. It is also not stored "in" the server. I don't really know how to rephrase this. Maybe just omit that sentence.
…into autogenerate_global_server_settings
|
Requires ClickHouse/ClickHouse#78282 first |
…into autogenerate_global_server_settings
… config sutogen settings
3 participants
Summary
Adds global settings to settings autogeneration script.
We will need to merge ClickHouse/ClickHouse#78012 first
Checklist