Skip to content

Conversation

@dhtclk
Copy link
Collaborator

@dhtclk dhtclk commented Sep 22, 2025

Summary

Indexing doc_type in algolia and adding the ability to filter by document type

image image

@dhtclk dhtclk requested a review from a team as a code owner September 22, 2025 17:27
@vercel
Copy link

vercel bot commented Sep 22, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
clickhouse-docs Ready Ready Preview Comment Sep 22, 2025 9:14pm
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
clickhouse-docs-jp Ignored Ignored Sep 22, 2025 9:14pm
clickhouse-docs-ru Ignored Ignored Preview Sep 22, 2025 9:14pm
clickhouse-docs-zh Ignored Ignored Preview Sep 22, 2025 9:14pm

Copy link
Member

@Blargian Blargian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the most part - I trust that it's working locally. Only feedback I have is that in light-mode it looks a little weird, see below:

Screenshot 2025-09-22 at 21 11 18

I feel like the drop down should maybe be positioned to the right of the search bar if possible. (or alternatively as check boxes below the search bar):

Screenshot 2025-09-22 at 21 12 10

Really nice addition! :)

Co-authored-by: Shaun Struwig <41984034+Blargian@users.noreply.github.com>
@dhtclk
Copy link
Collaborator Author

dhtclk commented Sep 22, 2025

LGTM for the most part - I trust that it's working locally. Only feedback I have is that in light-mode it looks a little weird, see below:

Screenshot 2025-09-22 at 21 11 18 I feel like the drop down should maybe be positioned to the right of the search bar if possible. (or alternatively as check boxes below the search bar): Screenshot 2025-09-22 at 21 12 10 Really nice addition! :)

I adjusted the styling the best I could based on the limitations of customizing doc search. it's quite fickle.
image

@dhtclk dhtclk merged commit 3825267 into main Sep 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants