Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom settings support in native protocol #993

Merged
merged 1 commit into from May 12, 2023
Merged

Custom settings support in native protocol #993

merged 1 commit into from May 12, 2023

Conversation

jkaflik
Copy link
Contributor

@jkaflik jkaflik commented May 10, 2023

Summary

This PR adds support for the custom settings in the native protocol.
It introduces an additional clickhouse.CustomSetting type, a value wrapper for the clickhouse.Setting type.
It can be passed to the clickhouse.Settings type as a value. If the value is provided with clickhouse.CustomSetting type, it will be passed to the server as a custom setting with an appropriate flag.
Only string type value is currently supported until this change is implemented.

Resolves #983

Checklist

Delete items not relevant to your PR:

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

Copy link
Contributor

@aramperes aramperes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jkaflik jkaflik marked this pull request as ready for review May 11, 2023 05:47
@jkaflik jkaflik merged commit 412b809 into main May 12, 2023
16 checks passed
@jkaflik jkaflik deleted the custom-settings branch March 14, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot provide custom settings using Native protocol
2 participants