From 286154067f22e5207ffcb26247876d8d5d3a0e19 Mon Sep 17 00:00:00 2001 From: Kanthi Subramanian Date: Mon, 25 Jul 2022 08:10:04 -0400 Subject: [PATCH 1/2] Add column name to exception message in addBatch() - InputBasedPreparedStatemente --- .../clickhouse/jdbc/internal/InputBasedPreparedStatement.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java index 39af07079..1796b779c 100644 --- a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java +++ b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java @@ -289,7 +289,7 @@ public void addBatch() throws SQLException { MappedFunctions functions = ClickHouseRowBinaryProcessor.getMappedFunctions(); for (int i = 0, len = values.length; i < len; i++) { if (!flags[i]) { - throw SqlExceptionUtils.clientError(ClickHouseUtils.format("Missing value for parameter #%d", i + 1)); + throw SqlExceptionUtils.clientError(ClickHouseUtils.format("Missing value for parameter #%d for column name %s", i + 1, columns.get(i))); } try { functions.serialize(values[i], config, columns.get(i), stream); From 675824c1bafef4add74b3838f65fd5ac0a8488d2 Mon Sep 17 00:00:00 2001 From: Kanthi Subramanian Date: Mon, 25 Jul 2022 08:13:26 -0400 Subject: [PATCH 2/2] Add column name to exception message in addBatch() - InputBasedPreparedStatement --- .../clickhouse/jdbc/internal/InputBasedPreparedStatement.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java index 1796b779c..8fb115bdc 100644 --- a/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java +++ b/clickhouse-jdbc/src/main/java/com/clickhouse/jdbc/internal/InputBasedPreparedStatement.java @@ -289,7 +289,7 @@ public void addBatch() throws SQLException { MappedFunctions functions = ClickHouseRowBinaryProcessor.getMappedFunctions(); for (int i = 0, len = values.length; i < len; i++) { if (!flags[i]) { - throw SqlExceptionUtils.clientError(ClickHouseUtils.format("Missing value for parameter #%d for column name %s", i + 1, columns.get(i))); + throw SqlExceptionUtils.clientError(ClickHouseUtils.format("Missing value for parameter #%d for column name %s", i + 1, columns.get(i).getColumnName())); } try { functions.serialize(values[i], config, columns.get(i), stream);