From b8a3984ec9cf1ae6777ca8e5c575940d0e6293a4 Mon Sep 17 00:00:00 2001
From: Nathan Debucquois <nathan.debucquois@gmail.com>
Date: Wed, 23 Oct 2024 23:26:43 +0200
Subject: [PATCH 1/2] Fix(clickhouse-client): Log the exception instead of
 printing the stacktrace when an error occur during a ping

---
 .../main/java/com/clickhouse/client/ClickHouseClient.java  | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseClient.java b/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseClient.java
index 100f9ea1f..084a890ed 100644
--- a/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseClient.java
+++ b/clickhouse-client/src/main/java/com/clickhouse/client/ClickHouseClient.java
@@ -40,6 +40,8 @@
 import com.clickhouse.data.ClickHouseValue;
 import com.clickhouse.data.ClickHouseValues;
 import com.clickhouse.data.ClickHouseWriter;
+import com.clickhouse.logging.Logger;
+import com.clickhouse.logging.LoggerFactory;
 
 /**
  * A unified interface defines Java client for ClickHouse. A client can only
@@ -56,6 +58,7 @@
  * implementation properly in runtime.
  */
 public interface ClickHouseClient extends AutoCloseable {
+    Logger LOG = LoggerFactory.getLogger(ClickHouseClient.class);
 
     /**
      * Returns a builder for creating a new client.
@@ -959,8 +962,8 @@ default boolean ping(ClickHouseNode server, int timeout) {
                     .get(timeout, TimeUnit.MILLISECONDS)) {
                 return resp != null;
             } catch (Exception e) {
-                // ignore
-                e.printStackTrace();
+                LOG.debug("Failed to connect to the server", e);
+                return false;
             }
         }
 

From 95851718659945989aa28b437d0a86caea14d651 Mon Sep 17 00:00:00 2001
From: Nathan Debucquois <nathan.debucquois@gmail.com>
Date: Wed, 23 Oct 2024 23:27:36 +0200
Subject: [PATCH 2/2] Tweak(): Add an error log when an error occurred during a
 ping for clientv2

---
 client-v2/src/main/java/com/clickhouse/client/api/Client.java | 1 +
 1 file changed, 1 insertion(+)

diff --git a/client-v2/src/main/java/com/clickhouse/client/api/Client.java b/client-v2/src/main/java/com/clickhouse/client/api/Client.java
index b14efa6e9..de235ef8b 100644
--- a/client-v2/src/main/java/com/clickhouse/client/api/Client.java
+++ b/client-v2/src/main/java/com/clickhouse/client/api/Client.java
@@ -1035,6 +1035,7 @@ public boolean ping(long timeout) {
             try (QueryResponse response = query("SELECT 1 FORMAT TabSeparated").get(timeout, TimeUnit.MILLISECONDS)) {
                 return true;
             } catch (Exception e) {
+                LOG.debug("Failed to connect to the server", e);
                 return false;
             }
         } else {