Added getShortArray & getStringArray implementation

[mzitnik]

Summary

Closes

Checklist

Delete items not relevant to your PR:

• Closes #
• Unit and integration tests covering the common scenarios were added
• A human-readable description of the changes was provided to include in CHANGELOG
• For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

[chernser]

I would like we have array of data and doing it in the loop - it keep test code compact.

[sonarqubecloud]

Quality Gate failed

Failed conditions
1 Security Hotspot
43.4% Coverage on New Code (required ≥ 80%)
4.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

[windsurf-bot]

Other comments (1)

• client-v2/src/main/java/com/clickhouse/client/api/data_formats/internal/AbstractBinaryFormatReader.java (648-648) The error messages in `getStringArray` are inconsistent with other array getter methods. For consistency, consider using similar error messages as the other array methods.

💡 To request another review, post a new comment with "/windsurf-review".

[windsurf-bot]

The getStringArray implementation should follow the same pattern as other array getters by using the getPrimitiveArray method. This would make the code more consistent and reduce duplication.

Suggested change

	public String[] getStringArray(String colName) {
	Object value = readValue(colName);
	if (value instanceof BinaryStreamReader.ArrayValue) {
	BinaryStreamReader.ArrayValue array = (BinaryStreamReader.ArrayValue) value;
	int length = array.length;
	if (!array.itemType.equals(String.class))
	throw new ClientException("Not A String type.");
	String [] values = new String[length];
	for (int i = 0; i < length; i++) {
	values[i] = (String)((BinaryStreamReader.ArrayValue) value).get(i);
	}
	return values;
	}
	throw new ClientException("Not ArrayValue type.");
	}
	@Override
	public String[] getStringArray(String colName) {
	try {
	return getPrimitiveArray(colName, String.class);
	} catch (ClassCastException | IllegalArgumentException e) {
	throw new ClientException("Value cannot be converted to an array of strings", e);
	}
	}

[windsurf-bot]

Unnecessary cast in the loop when accessing array elements. The value is already cast to BinaryStreamReader.ArrayValue earlier.

Suggested change

	values[i] = (String)((BinaryStreamReader.ArrayValue) value).get(i);
	values[i] = (String)array.get(i);

[windsurf-bot]

The JavaDoc comments for the new methods are incomplete. Consider adding descriptions of what these methods do, similar to other array getter methods in the interface.

Suggested change

	/**
	*
	* @param colName
	* @return
	*/
	short[] getShortArray(String colName);
	/**
	*
	* @param colName
	* @return
	*/
	String[] getStringArray(String colName);
	/**
	* Reads column with name `colName` as a short array.
	*
	* @param colName
	* @return
	*/
	short[] getShortArray(String colName);
	/**
	* Reads column with name `colName` as a string array.
	*
	* @param colName
	* @return
	*/
	String[] getStringArray(String colName);