Skip to content

Conversation

@slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Nov 11, 2025

Summary

An implementation of the protocol change introduced in ClickHouse/ClickHouse#88818.

Supercedes PR #384

Closes #332
Related to #378

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG

@slvrtrn slvrtrn requested a review from mshustov November 11, 2025 16:55
@codecov
Copy link

codecov bot commented Nov 11, 2025

Codecov Report

❌ Patch coverage is 89.58333% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
packages/client-common/src/utils/stream.ts 90.47% 1 Missing and 1 partial ⚠️
packages/client-node/src/result_set.ts 92.00% 2 Missing ⚠️
packages/client-common/src/utils/connection.ts 0.00% 0 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@slvrtrn
Copy link
Contributor Author

slvrtrn commented Nov 11, 2025

missing coverage
packages/client-common/src/utils/stream.ts

yeah, perhaps worth adding a unit test, even though it is mostly covered by the e2e

@slvrtrn
Copy link
Contributor Author

slvrtrn commented Nov 12, 2025

89.58% of diff hit (target 91.61%)

oh well.

@slvrtrn slvrtrn merged commit be2eff5 into main Nov 12, 2025
26 of 27 checks passed
@slvrtrn slvrtrn deleted the stream-err-handling branch November 12, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

An error occurred in a middle of a select stream processing should be thrown

2 participants