Skip to content

Fix macos stacktraces for 19.x #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025
Merged

Fix macos stacktraces for 19.x #52

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions libcxx/include/__exception/exception.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,12 @@
#endif

#ifdef STD_EXCEPTION_HAS_STACK_TRACE
#if defined(OS_DARWIN)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a comment here, saying that this is a ClickHouse-specific patch of LLVM + the motivation + (if possible) a reference to an issue.

extern "C" int backtrace(void **, int);
#else
extern "C" int unw_backtrace(void **, int);
#endif
#endif

namespace std { // purposefully not using versioning namespace

Expand Down Expand Up @@ -103,7 +107,11 @@ class _LIBCPP_EXPORTED_FROM_ABI exception {
int size = 0;
void capture() _NOEXCEPT
{
#if defined(OS_DARWIN)
size = backtrace(frames, capacity);
#else
size = unw_backtrace(frames, capacity);
#endif
}
#endif
};
Expand Down