New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't count uncompletable games in the completion percentage #52

Closed
Clidus opened this Issue Jul 3, 2014 · 2 comments

Comments

Projects
None yet
2 participants
@Clidus
Copy link
Owner

Clidus commented Jul 3, 2014

RE: Email from Shi9k

In the current release uncompletable games are actually counted as "Completed" games in the statistics. You can easily see this by filtering to just uncompletable games (I've attached a screenshot). You can see uncompletable games are counted in the "Completed" total and the completion percentage. Having thought about this more, I think this is actually wrong, and instead uncompletable should simply not be counted at all (except in the collection total). I will change this in the next release.

capture1

@Clidus Clidus added the enhancement label Jul 3, 2014

@Clidus Clidus self-assigned this Jul 3, 2014

Clidus added a commit that referenced this issue Jul 4, 2014

@Clidus Clidus closed this Jul 4, 2014

@nyxthewitch

This comment has been minimized.

Copy link

nyxthewitch commented Jul 5, 2014

Keep up the good work, Clidus!

@Clidus

This comment has been minimized.

Copy link
Owner

Clidus commented Jul 5, 2014

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment