New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cron job stuck on game that no longer exists #53

Open
Clidus opened this Issue Dec 30, 2014 · 1 comment

Comments

Projects
None yet
1 participant
@Clidus
Copy link
Owner

Clidus commented Dec 30, 2014

Cron job is stuck trying to update a game that doesn't exist.

http://www.giantbomb.com/api/game/36206/?api_key=872f26794f30fed7c9e69cf63788c628d17d772e&format=json

Seems like GB deleted the duplicate Stanley Parable page. Need to handle game deletions gracefully.

http://www.giantbomb.com/the-stanley-parable/3030-36206/

@Clidus Clidus added the bug label Dec 30, 2014

@Clidus Clidus self-assigned this Dec 30, 2014

Clidus added a commit that referenced this issue Jan 1, 2015

Fixed: Cron stuck on game that doesnt exist #53
Job now records error and skips game

@Clidus Clidus closed this Jan 1, 2015

@Clidus Clidus reopened this Jan 2, 2015

@Clidus

This comment has been minimized.

Copy link
Owner

Clidus commented Jan 2, 2015

Recorded response error from Giant Bomb and skipped in cron job to fix issue. Was caused by a duplicate of The Stanley Parable that was deleted. Changed link in users' collections to the other Stanley Parable.

Need to monitor how often this issue occurs and consider an automated way of fixing it.

Simplest solution; remove deleted game from all collections and notify user so they can correct the issue if they wish.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment