Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation and add a package.json file #11

Closed
wants to merge 1 commit into from

Conversation

juliengirault
Copy link
Contributor

Here a few suggestions:

  • I think this plugin should be made available via npm.
    • Introduced package.json
    • Removed L.Map.mergeOptions() from the plugin itself.
      • My suggestion would be to give these options actual default values, so the developer only has to override what he wants?
    • Helps importing the plugin in local project.
    • Helps version tracking/upgrading.
  • I documented the README config section a bit differently

@juliengirault juliengirault mentioned this pull request Mar 23, 2016
@atstp
Copy link
Contributor

atstp commented Mar 23, 2016

Github's pr-timeline above is a bit confusing at the moment. Basically, the histories along with most of package.json was merged.

The readme definitely needs a brush-up, and while I'm not yet 100% sold on config changes there could be some solid arguments for it — i'll open an issue in just a minute.

@atstp atstp closed this Mar 23, 2016
@juliengirault juliengirault deleted the improve_docs branch March 24, 2016 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants