Conversation
juntyr
approved these changes
Apr 8, 2025
Member
Author
|
Thank you for the review @juntyr ! I have addressed your comments. I have also opened an issue in the original implementation, asking for a more functional interface (NCAR/ldcpy#358). If they provide a better interface to the code we can then avoid having a custom version for our use case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the data SSIM metric described in https://ieeexplore.ieee.org/abstract/document/10319365. It is an adaption of the popular SSIM metric often used in compression to floating point data.
This implementation is directly based on the implementation of the authors at https://github.com/NCAR/ldcpy/blob/6c5bcb8149ec7876a4f53b0e784e9c528f6f14cb/ldcpy/calcs.py#L2516.
The official implementation makes assumptions about the input data that are specific to models developed at NCAR which is why we cannot use the official implementation directly.
In this PR I also adjusted the
collect_metrics.pyscript to deal with the fact that we have changed the directory structure to account for having multiple error bounds.