Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update read the docs for balsamic v12.0.0 #1153

Merged
merged 7 commits into from May 5, 2023

Conversation

mathiasbio
Copy link
Collaborator

This PR:

Updates read the docs for release 12.0.0 of balsamic.

Changes in the latest release of balsamic for reference:

Added:

Changed:

Fixed:

Changes in the read the docs made here:

Added:

  • Descriptions of which filters were added in WGS T / N for TIDDIT normal filtering
  • Update about maximum sv-size for VEP annotation

Removed:

  • WGS from list of sequencing types where VarDict is used (just a correction)

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@mathiasbio mathiasbio requested a review from ivadym May 4, 2023 11:58
@mathiasbio mathiasbio changed the title Update read the docs improve: update read the docs for balsamic v12.0.0 May 4, 2023
@mathiasbio mathiasbio marked this pull request as ready for review May 4, 2023 12:03
@mathiasbio mathiasbio requested a review from a team May 4, 2023 12:03
@mathiasbio mathiasbio changed the title improve: update read the docs for balsamic v12.0.0 fix: update read the docs for balsamic v12.0.0 May 4, 2023
Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic @mathiasbio 🥳

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

I have also spotted some erros: Dnascope is TGA and WGS, TNscope UMI is only TGA and NOT germline 🤦

In atlas is correct: https://atlas.scilifelab.se/production/data_analysis/workflows/balsamic/#data-delivery

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, I'll make the changes!

CHANGELOG.rst Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented May 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7f92f66) 99.31% compared to head (80d7615) 99.31%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release_12.0.0    #1153   +/-   ##
===============================================
  Coverage           99.31%   99.31%           
===============================================
  Files                  29       29           
  Lines                1756     1756           
===============================================
  Hits                 1744     1744           
  Misses                 12       12           
Flag Coverage Δ
unittests 99.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@mathiasbio mathiasbio merged commit fb7db6b into release_12.0.0 May 5, 2023
20 checks passed
@mathiasbio mathiasbio deleted the update_read_the_docs branch May 5, 2023 09:20
@ivadym ivadym mentioned this pull request May 10, 2023
14 tasks
ivadym added a commit that referenced this pull request May 10, 2023
### Added:
* PIP specific missing tools to config #1096
* Filtering script to remove normal variants from TIDDIT #1120
* Store TMB files in HK #1144

### Changed:
* Fixed all conda container dependencies #1096
* Changed --max_sv_size in VEP params to the size of chr1 for hg19 #1124
* Increased time-limit for sambamba_exon_depth and picard_markduplicates to 6 hours #1143
* Update cosmicdb to v97 #1147
* Updated read the docs with the changes relevant to mention #1153

### Fixed:
* Update cryptography version (39.0.1) due to security alert #1087
* Bump cryptography to v40.0.2 and gsutil to v5.23 #1154
* Pytest file saved in balsamic directory #1093
* Fix varcall_py3 container bcftools dependency error #1097
* AscatNgs container #1155
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants