Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cnvkit container #996

Merged
merged 2 commits into from Sep 17, 2022
Merged

fix: cnvkit container #996

merged 2 commits into from Sep 17, 2022

Conversation

khurrammaqbool
Copy link
Contributor

This PR:

Added: R packages to cnvkit container.

Review and tests:

  • Tests pass
  • Code review
  • New code is executed and covered by tests, and test approve

@codecov
Copy link

codecov bot commented Sep 17, 2022

Codecov Report

Base: 99.24% // Head: 99.24% // No change to project coverage 👍

Coverage data is based on head (80dd5d5) compared to base (697b022).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #996   +/-   ##
========================================
  Coverage    99.24%   99.24%           
========================================
  Files           29       29           
  Lines         1722     1722           
========================================
  Hits          1709     1709           
  Misses          13       13           
Flag Coverage Δ
unittests 99.24% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@ivadym ivadym left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CHANGELOG.rst Outdated
@@ -7,7 +7,7 @@ Added:
* Use of PON reference, if exists for CNVkit tumor-normal analysis https://github.com/Clinical-Genomics/BALSAMIC/pull/982
* Added PON version to CLI and config.json https://github.com/Clinical-Genomics/BALSAMIC/pull/983
* `cnvpytor` to varcallpy3 container https://github.com/Clinical-Genomics/BALSAMIC/pull/991

* R packages to cnvkit container
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* R packages to cnvkit container
* R packages to cnvkit container https://github.com/Clinical-Genomics/BALSAMIC/pull/996

@sonarcloud
Copy link

sonarcloud bot commented Sep 17, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@khurrammaqbool khurrammaqbool merged commit bcc693a into develop Sep 17, 2022
@khurrammaqbool khurrammaqbool deleted the fix/cnvkit_container branch September 17, 2022 13:28
@khurrammaqbool khurrammaqbool mentioned this pull request Dec 5, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants