Feature/env naming #874
Merged
Feature/env naming #874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added CLI for prepending prefix and appending suffix to conda environment names
lib/MIP/Set/Parameter.pm
Outdated
| $log->warn( | ||
| q{No environment name has been specified for MIP's main environment.}); | ||
| $log->warn(q{MIP will be installed in conda's base environment.}); | ||
| q{No environment name has been specified for MIP's main environment. Using default} |
There was a problem hiding this comment.
Please add the MIP's main environment to the log: qq{Using default $parameter_href->{environment_name}{emip}}
lib/MIP/Set/Parameter.pm
Outdated
| my ( $sec, $min, $hour, $mday, $mon, $year, $wday, $yday, $isdst ) = localtime time; | ||
| my $date = sprintf '%02d%02d%02d', $year % $ONE_HUNDRED, $mon + 1, $mday; | ||
|
|
||
| ## Set up conda environment names and prefix paths for environmnents | ||
| foreach my $environment (@environments) { |
There was a problem hiding this comment.
It would be nice to separate this foreach loop into a new sub which you can test the different scenarios in. It will make it easier to understand the logic and also to test it and then you do not have to test it in the calling sub
Typo Co-Authored-By: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
typo Co-Authored-By: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
more typos Co-Authored-By: Henrik Stranneheim <henrik.stranneheim@scilifelab.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes:
Standard environment names. Adds date by default as well as the possibility to add a prefix and suffix to the environment names.
Also some fixes around checking pip packages
How to test:
Expected outcome:
Review: