Skip to content

Conversation

@vsmart
Copy link
Member

@vsmart vsmart commented Jun 4, 2019

Before: no working map :(

before

After: with fixed Mapbox map

map

  • Closes Google Maps error #60
  • Switches over from Google maps to Mapbox GL
  • Adds a little ClojureBridge map marker

Todo before merging

  • Get a review
  • Decide on zoom level: do you like what's in the screenshot? Or should it be more zoomed-in for the locals to see where exactly the location is?
  • Set up a Mapbox account with custom token for this project ( I tested with a personal token)
  • Token storage strategy: should we just store it in the repository? Or how we can store it securely?

@vsmart
Copy link
Member Author

vsmart commented Jun 7, 2019

Regarding the token question, I did some research and the short answer is: there is no way to hide the secret using github pages. The way to secure the token is by setting strict scopes on the mapbox-side - then, it's also ok to put the token into the public repo. The token will be public on the website anyway, since this is client-side.

Source 1: https://stackoverflow.com/questions/42753225/how-to-safely-store-google-maps-api-key-in-public-repo-for-github-pages
Source 2: https://stackoverflow.com/questions/21939713/hide-api-key-for-a-github-page/21941683#21941683

@davidchambers
Copy link
Contributor

Thank you for fixing this problem, Franka! 🎉

@vsmart vsmart merged commit 1332467 into master Jun 25, 2019
@vsmart vsmart deleted the mapbox-map branch June 25, 2019 19:57
@davidchambers
Copy link
Contributor

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Google Maps error

3 participants