New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with invalid selected ranges #1067

Merged
merged 3 commits into from Nov 12, 2018

Conversation

Projects
None yet
2 participants
@Pankraty
Member

Pankraty commented Nov 11, 2018

Fixes #1066

@igitur igitur added this to the v0.94 milestone Nov 11, 2018

@igitur

I admit it's confusing but the .xlsx resources in ClosedXML/ClosedXML_Tests/Resource/Misc/ are meant for the LoadingTests input files. I've wanted to restructure the directories a while ago. Either add the file to the list of files in LoadingTests.cs (ps, that should actually be changed to an enumeration over the files, instead of files being specified individually - I'll do that later), or move the file to e.g. ClosedXML/ClosedXML_Tests/Resource/Other/SelectedRanges/

@Pankraty Pankraty force-pushed the Pankraty:InvalidSelectedRange branch from fbbe3e4 to 9aa302b Nov 12, 2018

@Pankraty

This comment has been minimized.

Member

Pankraty commented Nov 12, 2018

NP. I've moved the file and rebased the branch.

@Pankraty Pankraty force-pushed the Pankraty:InvalidSelectedRange branch from 9aa302b to cd3f705 Nov 12, 2018

@igitur

igitur approved these changes Nov 12, 2018

@igitur igitur merged commit caa981e into ClosedXML:release-candidate Nov 12, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment