New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference FastMember (unsigned) when building unsigned ClosedXML #1072

Merged
merged 1 commit into from Nov 19, 2018

Conversation

Projects
None yet
2 participants
@igitur
Member

igitur commented Nov 19, 2018

To avoid unnecessary binding redirects, we can reference FastMember (unsigned) when building unsigned ClosedXML.

@igitur igitur added this to the v0.94 milestone Nov 19, 2018

@igitur

This comment has been minimized.

Member

igitur commented Nov 19, 2018

Is this a breaking change? I suspect so...

@igitur igitur requested a review from Pankraty Nov 19, 2018

@igitur igitur changed the base branch from develop to release-candidate Nov 19, 2018

@Pankraty

Agree

@igitur igitur merged commit f6dccf4 into ClosedXML:release-candidate Nov 19, 2018

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@igitur igitur deleted the igitur:reference-unsigned-fastmember branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment