New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alternative implementation of pivot table formats #1129

Open
wants to merge 6 commits into
base: develop
from

Conversation

Projects
None yet
2 participants
@igitur
Copy link
Member

igitur commented Jan 10, 2019

@b0bi79 @Pankraty

Here is my alternative implementation. It removes the need for lambda functions and "builders". I think this is a cleaner API, althought the internals are a bit more messy than your implementation. Some of the new enum's could be better named. We can finalise that later.

I made some changes to e.g. XLPivotValues that should probably be submitted in a separate PR.

What do you think of this? Look at the unit test to see how to use it.

Closes #895

@igitur igitur added this to the v0.95 milestone Jan 10, 2019

@igitur igitur added the enhancement label Jan 10, 2019

@b0bi79

This comment has been minimized.

Copy link
Member

b0bi79 commented Jan 10, 2019

I like it

@igitur

This comment has been minimized.

Copy link
Member

igitur commented Jan 10, 2019

@b0bi79 Do you have more templates with pivot table formatting? Attach as many as you can please. We need to test this thoroughly.

By the way, how did you reverse-engineer this originally? The OpenXml pivot format spec is not obvious at all.

@b0bi79

This comment has been minimized.

Copy link
Member

b0bi79 commented Jan 10, 2019

You mean templates for ClosedXML.Report? So far, there are only two templates for Pivot. When I can use it in ClosedXML.Report, I will add more tests.

For reverse-engineer I studied how any format changes are reflected in the file and after that I looked in the specification what these elements and attributes mean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment