Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore _X (capital X) as XML escaping char #1155

Merged
merged 3 commits into from Mar 6, 2019

Conversation

Projects
None yet
2 participants
@igitur
Copy link
Member

igitur commented Mar 6, 2019

Remove own implementation of IsXmlChar
Case-insensitive decoding of hex strings
Ignore _X (capital X) as XML escaping char for decoding. Fixes #1154

@igitur igitur added the bug label Mar 6, 2019

@igitur igitur added this to the v0.95 milestone Mar 6, 2019

@igitur igitur requested a review from Pankraty Mar 6, 2019

@Pankraty

This comment has been minimized.

Copy link
Member

Pankraty commented Mar 6, 2019

Do I understand correctly that lowercase _x works fine?

@igitur

This comment has been minimized.

Copy link
Member Author

igitur commented Mar 6, 2019

Do I understand correctly that lowercase _x works fine?

Short answer, yes.

Long answer: Escaping/encoding unsupported characters will generate a string e.g. x0001 (represents Unicode character 1). Note the lowercase _x. Decoding/unescaping works correctly in recognising the lowercase _x.

This change is to avoid recognising _X as an escape character too.

@igitur igitur merged commit 4b33973 into ClosedXML:develop Mar 6, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@igitur igitur deleted the igitur:issue1154-xceed branch Mar 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.
You signed in with another tab or window. Reload to refresh your session. You signed out in another tab or window. Reload to refresh your session.