Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix initialization of default styles for XLCells, XLRows, XLColumns and XLRanges #1168

Merged
merged 4 commits into from Apr 1, 2019

Conversation

Projects
None yet
2 participants
@Pankraty
Copy link
Member

Pankraty commented Mar 30, 2019

#1134 did not fix the issue with the default cell styles completely. Many ClosedXML.Report tests were failing because the worksheet in the template had a non-standard style (Arial 8pt, to be specific) and some of the empty cells were initialized with the default value (Calibri 11 pt). In some cases, this affected the heights of the rows so it could not be just ignored.

@Pankraty

This comment has been minimized.

Copy link
Member Author

Pankraty commented Mar 30, 2019

cc @b0bi79

@Pankraty Pankraty changed the title Fix initialization of default styles for XLCells, XLRows, XLColumns and XLRanges WIP: Fix initialization of default styles for XLCells, XLRows, XLColumns and XLRanges Mar 30, 2019

@Pankraty Pankraty force-pushed the Pankraty:DefaultStyles branch 2 times, most recently from 36eef5f to 7b440d2 Mar 30, 2019

@Pankraty Pankraty changed the title WIP: Fix initialization of default styles for XLCells, XLRows, XLColumns and XLRanges Fix initialization of default styles for XLCells, XLRows, XLColumns and XLRanges Mar 30, 2019

@Pankraty Pankraty requested a review from igitur Mar 30, 2019

@Pankraty Pankraty force-pushed the Pankraty:DefaultStyles branch from 7b440d2 to e2d4ca3 Mar 31, 2019

@igitur igitur added this to the v0.95 milestone Mar 31, 2019

Show resolved Hide resolved ClosedXML/Excel/Rows/XLRows.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/XLWorkbook.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/XLWorkbook_Load.cs
@igitur
Copy link
Member

igitur left a comment

_

@igitur igitur merged commit 7337e7f into ClosedXML:develop Apr 1, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.