Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clear all RelId's if workbook is loaded from template. #1172

Merged

Conversation

Projects
None yet
2 participants
@igitur
Copy link
Member

igitur commented Apr 4, 2019

If a workbook is loaded with XLWorkbook.OpenFromTemplate(), it should be treated as brand new, i.e. no RelId's should be prepopulated.

@igitur igitur added this to the v0.96 milestone Apr 4, 2019

@igitur igitur requested a review from Pankraty Apr 4, 2019

@igitur igitur added the bug label Apr 4, 2019

@Pankraty

This comment has been minimized.

Copy link
Member

Pankraty commented Apr 4, 2019

Why not 0.95?

@igitur

This comment has been minimized.

Copy link
Member Author

igitur commented Apr 4, 2019

Ok, I guess we can squeeze it in.

@igitur igitur modified the milestones: v0.96, v0.95 Apr 4, 2019

@igitur igitur merged commit e05b2a8 into ClosedXML:develop Apr 4, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@igitur igitur deleted the igitur:clear-RelIds-if-loaded-from-template branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.