Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly dispose temporary memorystream #1174

Merged
merged 1 commit into from Apr 4, 2019

Conversation

Projects
None yet
2 participants
@igitur
Copy link
Member

igitur commented Apr 4, 2019

No description provided.

@igitur igitur added the enhancement label Apr 4, 2019

@igitur igitur added this to the v0.96 milestone Apr 4, 2019

@igitur igitur requested a review from Pankraty Apr 4, 2019

@Pankraty

This comment has been minimized.

Copy link
Member

Pankraty commented Apr 4, 2019

Did you have issues with this? Because as far as I remember MemoryStream.Dispose() method does nothing.

@igitur

This comment has been minimized.

Copy link
Member Author

igitur commented Apr 4, 2019

No, no issues. I'm just used to closing all streams properly.

@igitur igitur modified the milestones: v0.96, v0.95 Apr 4, 2019

@igitur igitur merged commit 3757451 into ClosedXML:develop Apr 4, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@igitur igitur deleted the igitur:dispose-temporary-memorystream branch Apr 4, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.