Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sparklines implementation #1175

Merged
merged 2 commits into from Jul 5, 2019

Conversation

Projects
None yet
2 participants
@Pankraty
Copy link
Member

commented Apr 6, 2019

I finally managed to get back to this task and now it is ready for review.

This PR replaces #907 and implements #454.

cc @ghronkrepps

@igitur igitur added this to the v0.96 milestone Apr 6, 2019

@igitur igitur self-requested a review Apr 6, 2019

@igitur

This comment has been minimized.

Copy link
Member

commented May 29, 2019

Please rebase.

@igitur igitur modified the milestones: v0.96, v0.95 May 29, 2019

@igitur

This comment has been minimized.

Copy link
Member

commented Jun 13, 2019

Please rebase and I will look at it soon after.

@Pankraty Pankraty force-pushed the Pankraty:Sparklines-refactoring branch from b567961 to a396105 Jul 4, 2019

@Pankraty

This comment has been minimized.

Copy link
Member Author

commented Jul 4, 2019

Yay, I did it! 😺

@igitur
Copy link
Member

left a comment

Just some minor comments. Please do a CodeMaid Clean on all touched files and a CodeMaid Organize and Clean on all new files. Otherwise, a very good and thorough PR.

Show resolved Hide resolved ClosedXML/Excel/EnumConverter.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/XLWorksheet.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/XLWorksheet.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/Cells/XLCellCopyOptions.cs
Show resolved Hide resolved ClosedXML/Excel/Ranges/XLRangeBase.cs Outdated
Show resolved Hide resolved ClosedXML_Examples/Sparklines/SampleSparklines.cs
Show resolved Hide resolved ClosedXML_Tests/Excel/Sparklines/SparklinesTests.cs Outdated
Show resolved Hide resolved ClosedXML_Tests/Excel/Sparklines/SparklinesTests.cs Outdated
Show resolved Hide resolved ClosedXML_Tests/Excel/Sparklines/SparklinesTests.cs

@Pankraty Pankraty force-pushed the Pankraty:Sparklines-refactoring branch from a396105 to b08aea5 Jul 5, 2019

@Pankraty Pankraty force-pushed the Pankraty:Sparklines-refactoring branch from b08aea5 to 6c96f8f Jul 5, 2019

@Pankraty

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

Done

@igitur

This comment has been minimized.

Copy link
Member

commented Jul 5, 2019

The last 3 commits (not e6e3f19) can be squashed, right?

@Pankraty

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

Yes. Give me a couple of minutes

@Pankraty Pankraty force-pushed the Pankraty:Sparklines-refactoring branch from 6c96f8f to 26dc3eb Jul 5, 2019

@Pankraty

This comment has been minimized.

Copy link
Member Author

commented Jul 5, 2019

Done

@igitur

igitur approved these changes Jul 5, 2019

@igitur igitur merged commit 6e1066d into ClosedXML:develop Jul 5, 2019

1 of 2 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
WIP Ready for review
Details

This was referenced Jul 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.