Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes in GetHashCode functions (1073) #1178

Merged
merged 2 commits into from Apr 9, 2019

Conversation

Projects
None yet
3 participants
@Pankraty
Copy link
Member

Pankraty commented Apr 9, 2019

This PR fixes the bug in XLNumberFormatKey equality check: the comparison was case-insensitive while it should be case-sensitive as, for example, mm stands for minutes while MM - for months.

Besides, it improves XLFontKey.GetHashCode in order to reduce memory allocations.

Closes #1073

@Pankraty Pankraty added the bug label Apr 9, 2019

@igitur

This comment has been minimized.

Copy link
Member

igitur commented Apr 9, 2019

How much of a performance gain is there?

@igitur igitur self-requested a review Apr 9, 2019

@igitur

igitur approved these changes Apr 9, 2019

@Pankraty

This comment has been minimized.

Copy link
Member Author

Pankraty commented Apr 9, 2019

Not much, though it may depend on a testing scenario. But the bug is nasty.

@igitur igitur added this to the v0.95 milestone Apr 9, 2019

@igitur igitur merged commit b12ab94 into ClosedXML:develop Apr 9, 2019

1 check passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@znakeeye

This comment has been minimized.

Copy link

znakeeye commented Apr 15, 2019

Actually quite much. The performance gain will be significant when under heavy memory pressure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.