Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for issue 1192 #1194

Open
wants to merge 2 commits into
base: develop
from

Conversation

Projects
None yet
3 participants
@UnlawfulCitizen
Copy link

commented Apr 29, 2019

What's this PR do?

Fix for issue ClosedXML#1192

Where should the reviewer start?

ClosedXML/Excel/Cells/XLCell.cs Line 679

How should this be manually tested?

By following the example in the Issue

Any background context you want to provide?

Screenshots (if appropriate)

Questions:

  • Is there a blog post? No

  • Does the knowledge base need an update? Maybe?

  • Does this add new (C#) dependencies? No

  • C# Code Review: @csreviewer

  • Test Automation Review: @csreviewer

Closes #1192

@Pankraty
Copy link
Member

left a comment

  1. Remove the comment - 'git blame' is sufficient enough.
  2. Please, add a unit test that fails without your changes and succeeds with them.

Thanks for participating!

Show resolved Hide resolved ClosedXML/Excel/Cells/XLCell.cs Outdated
Show resolved Hide resolved ClosedXML_Tests/Excel/Tables/TablesTests.cs Outdated
Show resolved Hide resolved ClosedXML_Tests/Excel/Tables/TablesTests.cs Outdated
Show resolved Hide resolved ClosedXML/Excel/Cells/XLCell.cs Outdated
@igitur

This comment has been minimized.

Copy link
Member

commented Apr 30, 2019

Looks good to me so far, but isn't RC-style addresses also disallowed? By playing around in Excel it seems so.

@UnlawfulCitizen

This comment has been minimized.

Copy link
Author

commented May 2, 2019

So Would the best path to be write a method much like IsValidA1Address to check for RC Style addresses, then do the same thing?

@UnlawfulCitizen

This comment has been minimized.

Copy link
Author

commented May 7, 2019

Is there anything else needed for this PR?

Show resolved Hide resolved ClosedXML/XLHelper.cs Outdated

@Pankraty Pankraty force-pushed the UnlawfulCitizen:develop branch from cdb2e7b to f247868 Jul 9, 2019

@Pankraty

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

I have squashed commits of @UnlawfulCitizen, added my own, and rebased on #1245. After that PR is merged this one will become basing on develop.

@igitur, I guess both of these PRs can be safely included in 0.95. What do you think?

@Pankraty Pankraty force-pushed the UnlawfulCitizen:develop branch from f247868 to fd17921 Jul 9, 2019

@Pankraty

This comment has been minimized.

Copy link
Member

commented Jul 9, 2019

Rebased

@igitur igitur added this to the v0.95 milestone Jul 9, 2019

@@ -28,6 +28,10 @@ public static class XLHelper
internal static readonly NumberStyles NumberStyle = NumberStyles.AllowDecimalPoint | NumberStyles.AllowLeadingSign | NumberStyles.AllowLeadingWhite | NumberStyles.AllowTrailingWhite | NumberStyles.AllowExponent;
internal static readonly CultureInfo ParseCulture = CultureInfo.InvariantCulture;

internal static readonly Regex RCSimpleRegex = new Regex(
@"^(r(((-\d)?\d*)|\[(-\d)?\d*\]))?(c(((-\d)?\d*)|\[(-\d)?\d*\]))?$"

This comment has been minimized.

Copy link
@igitur

igitur Jul 11, 2019

Member

And you call this a simple regex?

This comment has been minimized.

Copy link
@UnlawfulCitizen

UnlawfulCitizen Jul 16, 2019

Author

He did make it a little less simple. XD

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.