Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve performance of loading workbooks having many merged ranges (#1220) #1224

Merged
merged 1 commit into from Jun 4, 2019

Conversation

Projects
None yet
2 participants
@Pankraty
Copy link
Member

commented May 29, 2019

Fixes #1220

I prepared a test example with around 100K merged ranges. Before this PR it took around 15 seconds to open it, with this PR - only 8. It took way longer to generate the file.

1220_test.xlsx

BTW, this file is challenging even for Excel: it hangs noticeably when trying to navigate to the last used cell.

@igitur igitur self-requested a review Jun 4, 2019

@igitur igitur added the enhancement label Jun 4, 2019

@igitur igitur added this to the v0.95 milestone Jun 4, 2019

@igitur

igitur approved these changes Jun 4, 2019

@igitur igitur merged commit f88ac0a into ClosedXML:develop Jun 4, 2019

2 checks passed

WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Pankraty Pankraty deleted the Pankraty:1220_MergeLoading branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.