Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix null exception when saving a file #1307

Merged
merged 3 commits into from Nov 12, 2019
Merged

Fix null exception when saving a file #1307

merged 3 commits into from Nov 12, 2019

Conversation

@xsombra
Copy link
Contributor

xsombra commented Nov 8, 2019

When the file has a fill with a null PatternFill, it throws a
NullReferenceException on XLWorkbook.Save()

Xavier Lucatero
When the file has a fill with a null PatternFill, it throws a
NullReferenceException on XLWorkbook.Save()
@igitur

This comment has been minimized.

Copy link
Member

igitur commented Nov 8, 2019

Thanks for the contribution. Please reformat your code according to standard Visual Studio conventions. The normal "Format Document" action in Visual Studio should be enough.

@xsombra

This comment has been minimized.

Copy link
Contributor Author

xsombra commented Nov 11, 2019

Hello. Thank you for your comments. I uploaded the suggested changes.

@igitur

This comment has been minimized.

Copy link
Member

igitur commented Nov 12, 2019

@Pankraty You happy with this PR?

@igitur igitur added this to the v0.95 milestone Nov 12, 2019
@igitur igitur added the bug label Nov 12, 2019
@Pankraty

This comment has been minimized.

Copy link
Member

Pankraty commented Nov 12, 2019

Absolutely!

@igitur
igitur approved these changes Nov 12, 2019
@igitur igitur merged commit 6b0173a into ClosedXML:develop Nov 12, 2019
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@igitur

This comment has been minimized.

Copy link
Member

igitur commented Nov 12, 2019

@xsombra Thanks for the contribution. Please keep them coming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.