Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1325: PopulateAutoFilter range check #1326

Merged
merged 3 commits into from Mar 3, 2020
Merged

Conversation

@mathlang
Copy link
Contributor

mathlang commented Dec 18, 2019

Added check in PopulateAutoFilter to avoid invalid range and throwing ArgumentOutOfRangeException

mathieu.langlois added 2 commits Dec 18, 2019
mathieu.langlois
ClosedXML_Tests/ClosedXML_Tests.csproj Outdated Show resolved Hide resolved
@mathlang mathlang requested a review from Pankraty Dec 18, 2019
Copy link
Member

Pankraty left a comment

Looks good for me. The final word is for @igitur

@mathlang thank you for the contribution!

@igitur igitur added this to the v0.95 milestone Mar 3, 2020
@igitur
igitur approved these changes Mar 3, 2020
@igitur

This comment has been minimized.

Copy link
Member

igitur commented Mar 3, 2020

Fixes #1325

@igitur igitur merged commit 2d13cca into ClosedXML:develop Mar 3, 2020
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@igitur igitur added the enhancement label Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.