Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the Expression double conversion operator to handle string values #1359

Merged
merged 1 commit into from Mar 21, 2020

Conversation

@mathlang
Copy link
Contributor

mathlang commented Mar 2, 2020

Fixes issue #1358

@mathlang mathlang force-pushed the mathlang:issue1358-subexpressions branch 2 times, most recently from 091cfde to 3246f97 Mar 2, 2020
@igitur

This comment has been minimized.

Copy link
Member

igitur commented Mar 3, 2020

Please check whether #1233 doesn't already address this issue.

@mathlang

This comment has been minimized.

Copy link
Contributor Author

mathlang commented Mar 3, 2020

It looks like #1233 has the same issue. It's the same code that was moved to a new ConvertibleObject class. I commented in #1233.

@mathlang mathlang force-pushed the mathlang:issue1358-subexpressions branch from b6b6e0e to 1c5b5f2 Mar 20, 2020
@mathlang mathlang force-pushed the mathlang:issue1358-subexpressions branch from 1c5b5f2 to 4986d2c Mar 20, 2020
@igitur igitur merged commit 12f2039 into ClosedXML:develop Mar 21, 2020
2 checks passed
2 checks passed
WIP Ready for review
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@igitur

This comment has been minimized.

Copy link
Member

igitur commented Mar 21, 2020

Thanks for a good contribution. Keep them coming.

@igitur igitur added this to the v0.95 milestone Mar 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.