speed up rebuild in postgres #278
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change simply exempts all records that will not change in the update.
Since
reorder_with_parent_idis called a lot for rebuild! this leads to a huge performance boost for our data.(many small trees, we have some 10k records and 4k top level elements)
Great tests by the way. My first solution got the check wrong with respect to null values (
!=instead ofis distinct from)...I ran the tests for postgres only and one rails version, but the nature of the change should allow that.