New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup a skeletal webapp #1

Merged
merged 4 commits into from May 10, 2017

Conversation

Projects
None yet
3 participants
@uttu357
Member

uttu357 commented May 9, 2017

  • Setup react-router-dom, react-redux and redux-thunk
  • Add webpack dev/prod config for the latest version
  • Include MaterialUI to the application
  • Add ImmutableJS to the package

Using Yarn for dependency management.
Todo: Add Jest for component testing. Will add it as we start to write tests for components.

@uttu357 uttu357 requested review from deshraj and tocttou May 9, 2017

@uttu357 uttu357 self-assigned this May 9, 2017

@uttu357

This comment has been minimized.

Show comment
Hide comment
@uttu357

uttu357 May 10, 2017

Member

@deshraj Made the changes and moved it inside frontend..

Member

uttu357 commented May 10, 2017

@deshraj Made the changes and moved it inside frontend..

uttu357 added some commits May 9, 2017

Setup a skeletal webapp
- Setup react-router-dom, react-redux and redux-thunk
- Add webpack dev/prod config for the latest version
- Include MaterialUI to the application
- Add ImmutableJS to the package

Todo: Add Jest for component testing. Will add it as we start to write tests for components.
"presets": ["react-hmre"]
}
}
}

This comment has been minimized.

@deshraj

deshraj May 10, 2017

Member

Please add a newline here.

@deshraj

deshraj May 10, 2017

Member

Please add a newline here.

This comment has been minimized.

@uttu357

uttu357 May 10, 2017

Member

Done.

@uttu357

uttu357 May 10, 2017

Member

Done.

@deshraj deshraj merged commit 93a02e5 into master May 10, 2017

0 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/travis-ci/push The Travis CI build failed
Details

@deshraj deshraj deleted the setup branch May 10, 2017

namansood pushed a commit to namansood/CloudCV that referenced this pull request Jan 20, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment