New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add AWS and Docker scripts #10

Merged
merged 5 commits into from Jun 15, 2017

Conversation

Projects
None yet
2 participants
@uttu357
Member

uttu357 commented Jun 10, 2017

  • Add AWS and Docker scripts for staging, dev and production environments.
  • Add settings for staging and prod environments.
  • Add requirements for prod environment.

@uttu357 uttu357 added test and removed test labels Jun 10, 2017

@uttu357 uttu357 added test and removed test labels Jun 10, 2017

@uttu357 uttu357 requested a review from deshraj Jun 10, 2017

Show outdated Hide outdated docker/dev/django/Dockerfile Outdated
cd aws/production
# Replace the <AWS_ACCOUNT_ID> with the real ID
sed -i='' "s/<AWS_ACCOUNT_ID>/$AWS_ACCOUNT_ID/" Dockerrun.aws.json

This comment has been minimized.

@deshraj

deshraj Jun 14, 2017

Member

@uttu357 can we make the AWS_ACCOUNT_ID as an environment variable? I am not a fan of hard-coding the configuration keys. Also, please make sure that other variables are also not hardcoded.

@deshraj

deshraj Jun 14, 2017

Member

@uttu357 can we make the AWS_ACCOUNT_ID as an environment variable? I am not a fan of hard-coding the configuration keys. Also, please make sure that other variables are also not hardcoded.

This comment has been minimized.

@uttu357

uttu357 Jun 14, 2017

Member

AWS ACCOUNT ID is an environment variable everywhere! This takes the value from travis ci environment! Or your local environment.

@uttu357

uttu357 Jun 14, 2017

Member

AWS ACCOUNT ID is an environment variable everywhere! This takes the value from travis ci environment! Or your local environment.

This comment has been minimized.

@deshraj

deshraj Jun 15, 2017

Member

Sounds good.

@deshraj

deshraj Jun 15, 2017

Member

Sounds good.

This comment has been minimized.

@deshraj

deshraj Jun 15, 2017

Member

Quick question: $AWS_ACCOUNT_ID represents the environment variable, right? so what does <AWS_ACCOUNT_ID> represent?

@deshraj

deshraj Jun 15, 2017

Member

Quick question: $AWS_ACCOUNT_ID represents the environment variable, right? so what does <AWS_ACCOUNT_ID> represent?

This comment has been minimized.

@uttu357

uttu357 Jun 15, 2017

Member

"<AWS_ACCOUNT_ID>" is a just a string in the JSON file which is replaced by the environment variable by travisCI represented by $AWS_ACCOUNT_ID

@uttu357

uttu357 Jun 15, 2017

Member

"<AWS_ACCOUNT_ID>" is a just a string in the JSON file which is replaced by the environment variable by travisCI represented by $AWS_ACCOUNT_ID

Show outdated Hide outdated settings/prod.py Outdated
Show outdated Hide outdated settings/staging.py Outdated
CORS_ORIGIN_ALLOW_ALL = True
# Logging
LOGGING = {

This comment has been minimized.

@deshraj

deshraj Jun 14, 2017

Member

Did you copy logging part from EvalAI settings? If yes, then it needs to be changed since logging is not properly set in EvalAI as of now.

@deshraj

deshraj Jun 14, 2017

Member

Did you copy logging part from EvalAI settings? If yes, then it needs to be changed since logging is not properly set in EvalAI as of now.

This comment has been minimized.

@uttu357

uttu357 Jun 14, 2017

Member

Yeah! Will check it and make the required changes! 👍

@uttu357

uttu357 Jun 14, 2017

Member

Yeah! Will check it and make the required changes! 👍

@deshraj

This comment has been minimized.

Show comment
Hide comment
@deshraj

deshraj Jun 15, 2017

Member

Great work @uttu357 :) Merging this.

Member

deshraj commented Jun 15, 2017

Great work @uttu357 :) Merging this.

@deshraj deshraj merged commit 576aa4e into develop Jun 15, 2017

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@uttu357 uttu357 deleted the docker branch Jun 15, 2017

@uttu357 uttu357 removed the test label Jun 16, 2017

deshraj added a commit that referenced this pull request Oct 30, 2017

Release v1.1 (#31)
* CI/CD Setup: Add AWS and Docker scripts (#10)

* Backend: Add django models (#11)

* Fix docker script and superuser script (#12)

* Add Coveralls and Raven Configuration (#13)

* fix(docker-compose): Minor change in docker script (#15)

* Add Web App API (#14)

* feat(api): Add serializers

* Add api for contact

* feat(contact-api): Add tests

* feat(web_team): Add api and tests to retrieve team members

* Minor fix

* fix(settings): Minor dev settings fix

* Settings: Add datadog for logging (#16)

* Add middleware for saving request metrics (#17)

* fix(datadog): Add middleware for saving request metrics

* fix(middleware): Minor style fixes

* Add news and showcase frontend (#18)

* fix(docker): Fix nodejs docker script (#19)

* fix(express): Fix express dist script (#20)

- Remove unused socket.io dependency

* Fixed padding issues (#24)

* Added instructions for non-ssh users in README (#25)

* Feat(admin): Add analytics dashboard to django admin (#27)

* Add contact us feature (#28)

* Add demo embedding and addition of logs (#26)

* Minor fix on demo page (#29)

namansood pushed a commit to namansood/CloudCV that referenced this pull request Jan 20, 2018

Merge pull request Cloud-CV#10 from Cloud-CV/basicDragAndDrop
export graphdef + fixed shape issue + loading css
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment