New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis.yml #5

Merged
merged 2 commits into from May 12, 2017

Conversation

Projects
None yet
3 participants
@uttu357
Member

uttu357 commented May 12, 2017

  • Run tests for both Django and Node.js applications

The build is failing because of errors in frontend build script which are resolved by #4

@tocttou

This comment has been minimized.

Show comment
Hide comment
@tocttou

tocttou May 12, 2017

Are you sure you want to use python2 here?

tocttou commented May 12, 2017

Are you sure you want to use python2 here?

Show outdated Hide outdated .travis.yml
@deshraj

This comment has been minimized.

Show comment
Hide comment
@deshraj

deshraj May 12, 2017

Member

No, I don't think that should be a problem since it only works on python files and won't affect the js files. Anyways, you can ignore the frontend/ directory by setting the flake8 configuration in setup.cfg file. For reference, see this https://github.com/Cloud-CV/EvalAI/blob/master/setup.cfg

Member

deshraj commented May 12, 2017

No, I don't think that should be a problem since it only works on python files and won't affect the js files. Anyways, you can ignore the frontend/ directory by setting the flake8 configuration in setup.cfg file. For reference, see this https://github.com/Cloud-CV/EvalAI/blob/master/setup.cfg

@uttu357

This comment has been minimized.

Show comment
Hide comment
@uttu357

uttu357 May 12, 2017

Member

Sure will do the required! 👍

Member

uttu357 commented May 12, 2017

Sure will do the required! 👍

Run flake8 over the whole repository
- Add setup.cfg to ignore certail directories while linting
- Silence flake8 for unused imports in manage.py and settings
- Remove ununsed import sys from settings/common.py
@deshraj

This comment has been minimized.

Show comment
Hide comment
@deshraj

deshraj May 12, 2017

Member

Looks good. Merging this. :)

Member

deshraj commented May 12, 2017

Looks good. Merging this. :)

@deshraj deshraj merged commit f85653a into master May 12, 2017

1 of 2 checks passed

continuous-integration/travis-ci/push The Travis CI build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@uttu357 uttu357 deleted the add-travis branch May 12, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment