Fix the download submission file url in challenge controller. #1168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taranjeet
reviewed
Aug 14, 2017
| @@ -961,7 +961,7 @@ | |||
| vm.downloadChallengeSubmissions = function() { | |||
| if(vm.phaseId) { | |||
| var parameters = {}; | |||
| parameters.url = "challenges/"+ vm.challengeId + "/phase/" + vm.phaseId + "/download_all_submissions_file/" + vm.fileSelected + "/"; | |||
| parameters.url = "challenges/"+ vm.challengeId + "/phase/" + vm.phaseId + "/download_all_submissions/" + vm.fileSelected + "/"; | |||
There was a problem hiding this comment.
I am missing here the reason for this change. @RishabhJain2018 can you please point me out ?
|
@RishabhJain2018 : Thanks :) |
deshraj
pushed a commit
that referenced
this pull request
Oct 24, 2018
HargovindArora
pushed a commit
to HargovindArora/EvalAI
that referenced
this pull request
Nov 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@deshraj Please review this and merge this asap as the feature won't work without it.