Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
one comment here and I know that @sorenh doesn't always agree with me on this, but for such a simple change-set, it is not required to have so many commits. I like the idea of having as few commits as possible so as to keep history usable.
of coarse, the disadvantage to rebasing is that it's harder to understand how you are making changes once you start getting review. I think a reasonable compromise is to clean up history before you start soliciting feedback, then issue new comments in response to requests to change things.