Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-index pages #4

Closed
bglw opened this issue Sep 3, 2021 · 1 comment · Fixed by #18
Closed

Handle non-index pages #4

bglw opened this issue Sep 3, 2021 · 1 comment · Fixed by #18
Milestone
1.0 release

Comments

@bglw
Copy link
Contributor

bglw commented Sep 3, 2021

Currently, Pagebreak expects to be working on (and outputting) index.html files. Behavior needs to be defined for when working with, say, about.html — and what that means for the page URL template.
@bglw bglw added this to the 1.0 release milestone Sep 3, 2021
bglw added a commit that referenced this issue Sep 9, 2021
@bglw
Adding spec for non-index html pages (issue #4)
06240f1
@bglw
Copy link
Contributor Author

bglw commented Sep 9, 2021

Skipped test added in the above commit

@Tate-CC Tate-CC mentioned this issue Sep 21, 2021
Merged
@bglw bglw closed this as completed in #18 Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.0 release
Development

Successfully merging a pull request may close this issue.

Non index pages CloudCannon/pagebreak
1 participant
@bglw