Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework the scheduler and file utility #159

Open
GiantTreeLP opened this issue Aug 12, 2019 · 1 comment

Comments

@GiantTreeLP
Copy link
Member

commented Aug 12, 2019

The scheduler is very weird and wastes resources.
The TaskScheduler is very weirdly set up and requires major rewriting.

This is very noticable with long lasting tasks like copying a large template.

https://github.com/CloudNetService/CloudNet/blob/development/cloudnet-lib/src/main/java/de/dytanic/cloudnet/lib/utility/threading/Scheduler.java

https://github.com/CloudNetService/CloudNet/blob/development/cloudnet-lib/src/main/java/de/dytanic/cloudnet/lib/scheduler/TaskScheduler.java

It would be best to simply replace this large class with a ScheduledExecutorService

While we are at it, we should also rewrite the FileUtility to use ready-made methods directly from Java: https://github.com/CloudNetService/CloudNet/blob/development/cloudnet-wrapper/src/main/java/de/dytanic/cloudnetwrapper/util/FileUtility.java.

@issue-label-bot

This comment has been minimized.

Copy link

commented Aug 12, 2019

Issue-Label Bot is automatically applying the label feature_request to this issue, with a confidence of 0.94. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@GiantTreeLP GiantTreeLP added bug and removed feature_request labels Aug 12, 2019

@GiantTreeLP GiantTreeLP changed the title Rework the scheduler Rework the scheduler and file utility Aug 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.