Added Team color support to use in newer mc versions #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliarn
reviewed
Jul 12, 2019
| @@ -110,16 +112,29 @@ private void addTeamEntry(Player target, Player all, IPermissionGroup permission | |||
| if (team == null) team = all.getScoreboard().registerNewTeam(teamName); | |||
|
|
|||
| try { | |||
| Optional<Method> setColor = Optional.ofNullable(team.getClass().getDeclaredMethod("setColor", ChatColor.class)); | |||
There was a problem hiding this comment.
getDeclaredMethod() will never return Null, you could remove the optional. You can also cache the field, you dont need to request it everytime.
| if (setColor.isPresent()) { | ||
| Method method = setColor.get(); | ||
| method.setAccessible(true); | ||
| if (permissionGroup.getColor().length() != 0) { |
There was a problem hiding this comment.
Nullcheck would be better here, dont check the length
juliarn
reviewed
Jul 12, 2019
| import java.lang.reflect.Method; | ||
| import java.util.Optional; |
There was a problem hiding this comment.
I think this import is unused
| String suffix = permissionGroup.getSuffix(); | ||
|
|
||
| if (color != null && !color.isEmpty()) | ||
| method.invoke(team, ChatColor.getByChar(color.replaceAll("&", "").replaceAll("§", ""))); |
There was a problem hiding this comment.
Please check if the ChatColor is null or not, and add brackets after the if-statement.
| if (color != null) { | ||
| permissionGroup.setColor(color); | ||
| CloudPermissionsPermissionManagement.getInstance().updateGroup(permissionGroup); | ||
| method.invoke(team, ChatColor.getByChar(color.replaceAll("&", "").replaceAll("§", ""))); |
There was a problem hiding this comment.
Also check if the chatcolor is null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed white color name in mc version 1.13-1.14 issue
Perhaps prefix now can contain 2 other chars instead of the two player name color codes