Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more possibilties for plugin creators when using thirdperson #519

Closed
wants to merge 2 commits into from

Conversation

@karl-police
Copy link
Contributor

commented Aug 9, 2019

No description provided.

karl-police added some commits Aug 9, 2019

@VortixDev

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

Thanks for the PR, though if someone wants to use the setup of the existing third person plugin whilst implementing their own system, they can override the relevant functions - a "custom third person" mechanic is not needed for this.

@VortixDev VortixDev closed this Aug 9, 2019

@karl-police

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@VortixDev The mechanic does not add any disadvantages to the current one

@karl-police

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

@VortixDev also it doesn't need to be overriden anymore it can but it doesn't have to

@sanny-io

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

The disadvantage to this is that it's unnecessary. It's another way to do something that is already easily accomplished.

@karl-police

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

The disadvantage to this is that it's unnecessary. It's another way to do something that is already easily accomplished.

don't you get it that overriding is not really a nice thing?

@FilmsActionCZ

This comment has been minimized.

Copy link

commented Aug 9, 2019

+support

sounds lit

@sanny-io

This comment has been minimized.

Copy link
Member

commented Aug 9, 2019

don't you get it that overriding is not really a nice thing?

In this case, I don't see anything wrong with an override. What I think would be even better is if there was a hook that was called to enable third person. If the hook doesn't return anything, then the default third person will activate.

Or put the default function in the Clockwork table.

@karl-police

This comment has been minimized.

Copy link
Contributor Author

commented Aug 9, 2019

don't you get it that overriding is not really a nice thing?

In this case, I don't see anything wrong with an override. What I think would be even better is if there was a hook that was called to enable third person. If the hook doesn't return anything, then the default third person will activate.

you have to know that player NWBool is set per client not for everyone at the same time, each has a different value, there is no problem. This is the best solution I come with.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.