From 3207db490963c066c496cc1531798806061ce50d Mon Sep 17 00:00:00 2001
From: terryherbert <46780257+terryherbert@users.noreply.github.com>
Date: Fri, 26 Jan 2024 20:45:33 +0000
Subject: [PATCH] Update SubClientLoginSerializer_v291.java

Fix serialization of SubClientLogin
---
 .../serializer/SubClientLoginSerializer_v291.java  | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v291/serializer/SubClientLoginSerializer_v291.java b/bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v291/serializer/SubClientLoginSerializer_v291.java
index 070811559..2832ef791 100644
--- a/bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v291/serializer/SubClientLoginSerializer_v291.java
+++ b/bedrock-codec/src/main/java/org/cloudburstmc/protocol/bedrock/codec/v291/serializer/SubClientLoginSerializer_v291.java
@@ -10,6 +10,7 @@
 import org.cloudburstmc.protocol.bedrock.packet.SubClientLoginPacket;
 import org.cloudburstmc.protocol.common.util.VarInts;
 import org.jose4j.json.internal.json_simple.JSONArray;
+import org.jose4j.json.internal.json_simple.JSONObject;
 import org.jose4j.json.internal.json_simple.JSONValue;
 import org.jose4j.json.internal.json_simple.parser.ParseException;
 
@@ -25,7 +26,11 @@ public class SubClientLoginSerializer_v291 implements BedrockPacketSerializer<Su
     public void serialize(ByteBuf buffer, BedrockCodecHelper helper, SubClientLoginPacket packet) {
         JSONArray array = new JSONArray();
         array.addAll(packet.getChain());
-        String chainData = array.toJSONString();
+
+        JSONObject json = new JSONObject();
+        json.put("chain", array);
+
+        String chainData = json.toJSONString();
         int chainLength = ByteBufUtil.utf8Bytes(chainData);
         String extraData = packet.getExtra();
         int extraLength = ByteBufUtil.utf8Bytes(extraData);
@@ -43,9 +48,12 @@ public void deserialize(ByteBuf buffer, BedrockCodecHelper helper, SubClientLogi
 
         try {
             Object json = JSONValue.parseWithException(readString(jwt).toString());
-            checkArgument(json instanceof JSONArray, "Expected JSON array for login chain");
+            checkArgument(json instanceof JSONObject && ((JSONObject) json).containsKey("chain"), "Invalid login chain");
+
+            Object chain = ((JSONObject) json).get("chain");
+            checkArgument(chain instanceof JSONArray, "Expected JSON array for login chain");
 
-            for (Object node : (JSONArray) json) {
+            for (Object node : (JSONArray) chain) {
                 checkArgument(node instanceof String, "Expected String in login chain");
                 packet.getChain().add((String) node);
             }